Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

intorduce LegacyTests suite #623

Merged
merged 7 commits into from
Aug 9, 2019
Merged

intorduce LegacyTests suite #623

merged 7 commits into from
Aug 9, 2019

Conversation

winsvega
Copy link
Collaborator

@winsvega winsvega commented Aug 7, 2019 •
edited
Loading

copy existing GeneralStateTests into LegacyTests suite

Rationale:

  • Regeneration of tests for previous forks would not be needed with any upcoming update for a specific test for new forks.
  • Sealing means we would not break any of Legacy tests by accident when making changes for new fork
  • This will reduce the amount of tests required for a client to run. Because no need to run tests on LegacyForks all the time. So time to execute most recent tests will be much shorter. Legacy tests required to check that client is able to sync with existing mainchain.
  • (-) This will increase the amount of data files in the repo by over 800Mb per each sealing.

@winsvega winsvega merged commit 65529e0 into develop Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@winsvega